Opened 5 years ago
Closed 19 months ago
#1701 closed defect (fixed)
[PATCH] Vorbis-tools-1.4.0 fails to compile with gcc2
| Reported by: | scottmc | Owned by: | msmith@… |
|---|---|---|---|
| Milestone: | Component: | Vorbis Tools | |
| Version: | trunk | Severity: | normal |
| Keywords: | Cc: | ||
| Parent Tickets: |
Description
Making all in vcut make[2]: Entering directory `/boot/develop/haikuports/media-sound/vorbis-tools/work/vorbis-tools-1.4.0/vcut' source='vcut.c' object='vcut.o' libtool=no \
DEPDIR=.deps depmode=gcc /bin/sh ../depcomp \ gcc -DLOCALEDIR=\"/boot/common/share/locale\" -DHAVE_CONFIG_H -I. -I.. -I/boot/common/include -I/boot/common/include -I../include -I../intl -I/boot/common/include -O2 -fsigned-char -g -O2 -c vcut.c
/boot/develop/haikuports/media-sound/vorbis-tools/work/vorbis-tools-1.4.0/vcut/vcut.c: In function `open_output_stream': /boot/develop/haikuports/media-sound/vorbis-tools/work/vorbis-tools-1.4.0/vcut/vcut.c:243: parse error before `int' /boot/develop/haikuports/media-sound/vorbis-tools/work/vorbis-tools-1.4.0/vcut/vcut.c:244: `rv' undeclared (first use in this function) /boot/develop/haikuports/media-sound/vorbis-tools/work/vorbis-tools-1.4.0/vcut/vcut.c:244: (Each undeclared identifier is reported only once /boot/develop/haikuports/media-sound/vorbis-tools/work/vorbis-tools-1.4.0/vcut/vcut.c:244: for each function it appears in.) make[2]: * [vcut.o] Error 1 make[2]: Leaving directory `/boot/develop/haikuports/media-sound/vorbis-tools/work/vorbis-tools-1.4.0/vcut' make[1]: * [all-recursive] Error 1 make[1]: Leaving directory `/boot/develop/haikuports/media-sound/vorbis-tools/work/vorbis-tools-1.4.0' make: * [all] Error 2
Moving int rv to the top of the function then allows vorbis-tools-1.4.0 to fully build. Patch attached.
Subtickets
Attachments (1)
Change History (4)
Changed 5 years ago by scottmc
comment:1 follow-up: ↓ 2 Changed 3 years ago by scottmc
comment:2 in reply to: ↑ 1 Changed 2 years ago by scottmc
Replying to scottmc:
Ping. Any change we'll see this get applied any time soon? It's a simple fix that's been sitting for 2+ years. -scottmc
Anybody? Patch is attached. It's a simple patch, easy to review. It allows building on a gcc2 Haiku, I suspect it may fix other platforms that still make use of c89 era compilers.
comment:3 Changed 19 months ago by gmaxwell
- Resolution set to fixed
- Status changed from new to closed
Ping. Any change we'll see this get applied any time soon? It's a simple fix that's been sitting for 2+ years. -scottmc